fix(stdlib): string writers terminate their own output (#1817) - #1834
Merged
Conversation
The *_TO_STRING writers relied on the caller zero-filling the whole result buffer: they wrote content without a trailing terminator, and TIME_TO_STRING_EXT even located its write position by scanning for the first zero byte. STRING_TO_WSTRING_EXT, CHAR_TO_STRING and WCHAR_TO_WSTRING had the same gap; the string_functions writers already terminate through the encoders. Every writer now terminates what it writes (via a cursor-tracking write_terminated helper for the formatted conversions), so results stay well-formed regardless of the destination buffer's prior contents. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 6d4efe1)
Build Artifacts🪟 Windows
From workflow run 🐧 Linux
From workflow run |
volsa
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1817 to
release/1.0.x(cherry-pick of 6d4efe1).🤖 Generated with Claude Code