ci: widen the e2e setup-bun guard to cover the Linux self-hosted runners - #38
Merged
Conversation
The guard here was `runner.os != 'Windows'`, copied from rust-tests.yml — where it is correct, because that job pins `runs-on: [self-hosted, windows]`. The e2e jobs are bare `[self-hosted]` and can land on the Linux boxes, where the guard lets setup-bun run and hit the other form of the same failure: Windows: EBUSY: resource busy or locked, copyfile '...bun.exe' Linux: ETXTBSY: text file is busy, copyfile '.../bun' -> '/home/ubuntu/.bun/bin/bun' Both are setup-bun downloading bun over a shared install that is already there and may be executing. Gating on the runner environment covers both, and leaves a GitHub-hosted runner installing bun normally. Same change as ci.yml in PR #37, which is where the Linux form actually bit.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #37, which fixed the same thing in
ci.yml.e2e-tests.ymlalready had a setup-bun workaround, guarded withrunner.os != 'Windows'. Thatguard was copied from
rust-tests.yml, where it is correct — that job pinsruns-on: [self-hosted, windows], so the condition exactly identifies its self-hosted runner.The e2e jobs are bare
runs-on: [self-hosted]and can land on the Linux boxes. There the guardis true, so
setup-bunruns — and hits the other form of the same failure:Both are
setup-bundownloading bun over a shared install that is already present and may beexecuting. Gating on the runner environment covers both, and a GitHub-hosted runner still
installs bun normally.
This matters more here than in
ci.yml: E2E runs on every PR todevelop, so this is theworkflow best placed to produce a random red X on unrelated work.