Add Settings controls for terminal font weight - #58
Merged
Conversation
xterm's fontWeight/fontWeightBold were hard-coded (normal/bold), making SGR-bold prompt/output text read heavier than users wanted with no way to adjust it. Adds Font Weight and Bold Text Weight dropdowns under Settings > Appearance, wired through settingsSlice (persisted + hydrated), TerminalEngine.setFontWeight() for live updates, and the Appearance category's dirty-tracking/revert baseline.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fontWeight/fontWeightBoldwere hard-coded (normal/bold), so SGR-bold prompt/output text always rendered at CSS 700 with no way to adjust it.settingsSlice(persisted + hydrated from config.json, with validation since config.json is hand-editable),TerminalEngine.setFontWeight()for live updates without remount, and the Appearance category's dirty-tracking/revert baseline so "Discard changes" works correctly.TerminalPane-owned engine's DOM element rather than owning its own engine instance.Test plan
bun run typecheckclean@termflow/terminal-coretest suite (724 tests, 47 suites) passingsettingsDirty+SettingsPage/TerminalDisplay/TerminalPane/settingsSlicejest suites passing