Data nodes and local sync - Misc improvements 07/08 - #161
Merged
paul-fresquet merged 2 commits intoAug 7, 2025
Merged
Conversation
paul-fresquet
marked this pull request as ready for review
August 7, 2025 05:33
paul-fresquet
deleted the
feature/data-nodes-and-local-sync-misc-improvements
branch
August 7, 2025 05:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the session reset logic in the ByteSync server codebase, moving the responsibility from
CloudSessionsServiceto a more granular command handler and repository approach. It also updates the corresponding unit tests and improves logging for better observability.Refactoring session reset logic
CloudSessionsServiceclass to theResetSessionCommandHandler, which now directly interacts withICloudSessionsRepository,IInventoryService,ISynchronizationService,ISharedFilesService, andIInvokeClientsServicefor a more modular and testable design. (src/ByteSync.ServerCommon/Commands/CloudSessions/ResetSessionCommandHandler.cs[1]src/ByteSync.ServerCommon/Services/CloudSessionsService.cs[2] [3]src/ByteSync.ServerCommon/Interfaces/Services/ICloudSessionsService.cs[4]Logging and observability
Program.csand of session resets in the command handler for improved monitoring and troubleshooting. (src/ByteSync.Functions/Program.cs[1]src/ByteSync.ServerCommon/Commands/CloudSessions/ResetSessionCommandHandler.cs[2]Unit test updates
ResetSessionCommandHandlerTests) has been updated to verify calls to all involved services and repositories, ensuring the new logic is properly exercised and validated. (tests/ByteSync.ServerCommon.Tests/Commands/CloudSessions/ResetSessionCommandHandlerTests.cs[1] [2]Dependency and interface cleanup
ResetSessionmethod fromICloudSessionsService, reflecting the new separation of concerns. (src/ByteSync.ServerCommon/Interfaces/Services/ICloudSessionsService.cs[1]src/ByteSync.ServerCommon/Services/CloudSessionsService.cs[2] [3] [4]