refactor!: remove the sql.glaredb target (seems no longer maintained) - #6172
refactor!: remove the sql.glaredb target (seems no longer maintained)#6172eitsupi wants to merge 7 commits into
sql.glaredb target (seems no longer maintained)#6172Conversation
prql-bot
left a comment
There was a problem hiding this comment.
Removing the target looks right — GlareDB's last release was in 2024 and the runner has been disabled in mod.rs since then, so nothing here was actually being exercised.
Three things outstanding:
Snapshots need regenerating. cargo test -p prqlc --test integration fails with 18 snapshot mismatches on this branch — the compileall snapshots still carry +++ glaredb diff sections, and the lex/debug_lineage snapshots still contain the removed glaredb:skip comment tokens:
queries::compileall::{append_select_compute, arithmetic, group_all, math_module, pipelines, read_csv}
queries::debug_lineage::{aggregation, date_to_text, loop_01, switch, text_module, window}
queries::lex::{aggregation, date_to_text, loop_01, switch, text_module, window}
Fix the stray comment line first (inline suggestion below), then cargo insta test -p prqlc --test integration --accept — otherwise the orphaned line gets baked into the regenerated snapshots.
tests/integration/dbs/README.md is now stale. Under ## External DBs it still says "(ClickHouse and GlareDB runners exist but are currently disabled in mod.rs.)" — only the ClickHouse one remains. That file isn't in the diff; happy to push a commit with the README line and the snapshot regeneration if that's useful.
No CHANGELOG.md entry. Dropping a compile target is user-facing, and the contributing guide asks for a line under ## [unreleased] — this one would fit under a breaking-change/Integrations heading.
sql.glaredb target (seems no longer maintained)sql.glaredb target (seems no longer maintained)
prql-bot
left a comment
There was a problem hiding this comment.
Tests pass on this branch now (cargo test -p prqlc — 78 lib + 484 integration, all green), and the removal is complete in code: no glaredb references remain in dialect.rs, std.sql.prql, the Elixir bindings, the docker-compose/runner setup, or the book's target list.
Two leftovers, neither blocking:
22 snapshot files still carry the removed glaredb:skip comments in their expression: metadata header — e.g. integration__queries__fmt__switch.snap still starts expression: "# glaredb:skip (May be a bag of String type conversion for Postgres Client)\n# mssql:test\n…". Insta doesn't compare that field (force_update is commented out in .config/insta.yaml), so the suite is green, but a grep for glaredb after this merges still hits all 22. 16 of them clean up with:
INSTA_FORCE_UPDATE=1 cargo test -p prqlc --test integrationThe other 6 are the integration__queries__results__* snapshots (aggregation, date_to_text, loop_01, switch, text_module, window), which only regenerate under --features=test-dbs against live databases — so a complete cleanup needs the external-DB job. Reasonable to leave all of it if the churn isn't worth it; just noting it so it's a choice rather than an oversight.
CHANGELOG.md entry is still outstanding — dropping a compile target is user-facing, and removing the Dialect::GlareDb variant is a breaking change for library users. Under **Integrations**: in ## [unreleased]:
- Remove the `sql.glaredb` target, which is no longer maintained upstream.
(@eitsupi, #6172)The contributing guide explicitly allows a changelog-only follow-up PR, so this needn't hold the merge.
Happy to push a commit with either or both if that's useful.
Minor: the PR title has a misplaced backtick — remove the `sql.glaredb target` reads better as remove the `sql.glaredb` target, and the title lands in the release notes.
|
@prql-bot Please update the integration tests snapshots. |
prql-bot
left a comment
There was a problem hiding this comment.
Snapshot regeneration checks out — the 16 updated expression: headers now match their .prql sources exactly (verified switch.prql and date_to_text.prql byte-for-byte against the new metadata), and no snapshot bodies moved. glaredb now only survives in the six results__* snapshots that need the external-DB job, plus the changelog entry itself.
One wording fix on the changelog line, suggested inline — it lands verbatim in the release notes.
Co-authored-by: prql-bot <107324867+prql-bot@users.noreply.github.com>
|
Done — pushed 9e6ff4e. Your Verified: for all 6, the How the 6 were identified and fixed
For each of the 6, the check was: decode the |
It seems development of GlareDB ended last year.
Since it was never tested after the fully rewritten, I think its removal makes sense.