[Bug] Unable to bypass $UseShellExecute when $WindowsStyle = 'Hidden' in function Execute-Process

[LFM8787]

Prerequisites

• Ensure you write a short, descriptive title after [Bug] above.
• Make sure to search for any existing issues before filing a new one.
• Verify you are able to reproduce the issue with the latest released version

PSAppDeployToolkit version

3.10.2

Describe the bug

Since change commited in 6d250d8 it's impossible to execute a Hidden windows without triggering UseShellExecute.

This collides with the function Test-ToastNotificationAvailability from PSADT.ToastNotification extension, more preciselly:

$null = [Windows.UI.Notifications.ToastNotificationManager, Windows.UI.Notifications, ContentType = WindowsRuntime]

$ToastNotificationManager = [Windows.UI.Notifications.ToastNotificationManager]::CreateToastNotifier($AppUserModelId)

Steps to reproduce

Invoke Execute-Process function with bound parameter(s):

Parameter Value

---

[-PassThru] True
[-SecureParameters] False
[-CreateNoWindow] True
[-WindowStyle] Hidden
[-Parameters] -ExecutionPolicy Bypass -Window Normal -EncodedCommand JABBAHAAcABVAHMAZQByAE0AbwBkAGUAbABJAGQAIAA9ACAAJwBQAFMAQQBEAFQALgBUAG8AYQBzAHQATgBvAHQAaQBmAGkAYwBhAHQAaQBvAG4AJwA7AA0ACgB0AHIAeQAgAHsADQAKACQAbgB1AGwAbAAgAD0AIABbAFcAaQBuAGQAbwB3AHMALgBVAEkALgBOAG8AdABpAGYAaQBjAGEAdABpAG8AbgBzAC4AVABvAGEAcwB0AE4AbwB0AGkAZgBpAGMAYQB0AGkAbwBuAE0AYQBuAGEAZwBlAHIALAAgAFcAaQBuAGQAbwB3AHMALgBVAEkALgBOAG8AdABpAGYAaQBjAGEAdABpAG8AbgBzACwAIABDAG8AbgB0AGUAbgB0AFQAeQBwAGUAIAA9ACAAVwBpAG4AZABvAHcAcwBSAHUAbgB0AGkAbQBlAF0ADQAKACQAVABvAGEAcwB0AE4AbwB0AGkAZgBpAGMAYQB0AGkAbwBuAE0AYQBuAGEAZwBlAHIAIAA9ACAAWwBXAGkAbgBkAG8AdwBzAC4AVQBJAC4ATgBvAHQAaQBmAGkAYwBhAHQAaQBvAG4AcwAuAFQAbwBhAHMAdABOAG8AdABpAGYAaQBjAGEAdABpAG8AbgBNAGEAbgBhAGcAZQByAF0AOgA6AEMAcgBlAGEAdABlAFQAbwBhAHMAdABOAG8AdABpAGYAaQBlAHIAKAAkAEEAcABwAFUAcwBlAHIATQBvAGQAZQBsAEkAZAApAA0ACgBpAGYAIAAoACQAVABvAGEAcwB0AE4AbwB0AGkAZgBpAGMAYQB0AGkAbwBuAE0AYQBuAGEAZwBlAHIALgBTAGUAdAB0AGkAbgBnAC4AdgBhAGwAdQBlAF8AXwAgAC0AaQBzACAAWwBpAG4AdABdACkAIAB7AA0ACgByAGUAdAB1AHIAbgAgACQAVABvAGEAcwB0AE4AbwB0AGkAZgBpAGMAYQB0AGkAbwBuAE0AYQBuAGEAZwBlAHIALgBTAGUAdAB0AGkAbgBnAC4AdgBhAGwAdQBlAF8AXwANAAoAfQANAAoAZQBsAHMAZQAgAHsADQAKAHIAZQB0AHUAcgBuACAAIgBuAHUAbABsACIADQAKAH0ADQAKAH0ADQAKAGMAYQB0AGMAaAAgAHsADQAKAHIAZQB0AHUAcgBuACAAJABfAC4ARQB4AGMAZQBwAHQAaQBvAG4ALgBNAGUAcwBzAGEAZwBlAA0ACgB9AA0ACgA=
[-Path] C:\Windows\system32\WindowsPowerShell\v1.0\powershell.exe
[-WorkingDirectory] C:\Windows\system32\WindowsPowerShell\v1.0
[-ContinueOnError] False
[-ExitOnProcessFailure] False

Environment data

OsName : Microsoft Windows 10 Pro
OsDisplayVersion : Microsoft Windows 10 Pro
OsOperatingSystemSKU : 48
OsArchitecture : 64 bits
WindowsVersion : 2009
WindowsProductName : Windows 10 Pro
WindowsBuildLabEx : 19041.1.amd64fre.vb_release.191206-1406

[LFM8787]

Simple solution to allow mortal people to dodge this new limitation 😃 :

## If the WindowStyle parameter is set to 'Hidden', set the UseShellExecute parameter to '$true'.
If ($WindowStyle -eq 'Hidden' -and -not $PSBoundParameters.ContainsKey('UseShellExecute')) {
    $UseShellExecute = $true
}

[mjr4077au]

Simple solution to allow mortal people to dodge this new limitation 😃 :

## If the WindowStyle parameter is set to 'Hidden', set the UseShellExecute parameter to '$true'.
If ($WindowStyle -eq 'Hidden' -and -not $PSBoundParameters.ContainsKey('UseShellExecute')) {
    $UseShellExecute = $true
}

@LFM8787 thanks for this report, I've patched it in our v4 branch in this manner. I agree, if a caller is explicitly passing a parameter because they know what they're doing, we should honour it.