fix: allow reactivating legacy ASHA users with no facility mapped - #145
Conversation
Reactivating a soft-deleted USR row was hitting "Facility (SC) is mandatory for ASHA role" for pre-existing ASHA users created before that rule existed, because the reactivation check re-fetched the row via findById() which returned the same JPA-managed instance already mutated by the caller (Open-Session-In-View shares one L1 cache per request), so the old-vs-new deleted comparison always failed. saveRoleMappingeditedData now takes a wasDeleted flag captured by the caller before mutation, and waives only the facility-mandatory check on reactivation — facility soft-delete and SC-level checks still run whenever a facility is present, so a reactivated row can't silently resume pointing at a facility that went stale while inactive. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
2 participants
Reactivating a soft-deleted USR row was hitting "Facility (SC) is mandatory for ASHA role" for pre-existing ASHA users created before that rule existed, because the reactivation check re-fetched the row via findById() which returned the same JPA-managed instance already mutated by the caller (Open-Session-In-View shares one L1 cache per request), so the old-vs-new deleted comparison always failed.
saveRoleMappingeditedData now takes a wasDeleted flag captured by the caller before mutation, and waives only the facility-mandatory check on reactivation — facility soft-delete and SC-level checks still run whenever a facility is present, so a reactivated row can't silently resume pointing at a facility that went stale while inactive.
📋 Description
JIRA ID:
Please provide a summary of the change and the motivation behind it. Include relevant context and details.
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.