feat(registrar): auto-load service-point worklist on search page open - #89
Draft
gkbishnoi07 wants to merge 1 commit into
Draft
feat(registrar): auto-load service-point worklist on search page open#89gkbishnoi07 wants to merge 1 commit into
gkbishnoi07 wants to merge 1 commit into
Conversation
the registrar search page opened empty ("No Records Found") until a manual
search. on init, load the beneficiaries already registered at the current
service point via getRegistrarWorklist(spID) and show them in the results
table. the worklist API returns lighter records than search, so rows are
mapped to the table shape and failures stay silent (empty table fallback).
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On the registrar Search page, auto-load the beneficiaries already registered at the current service point when the page opens, instead of showing an empty "No Records Found" table until a manual search.
registrar.service.ts:getRegistrarWorklist(spID)→POST registrarWorkListData.search.component.ts:ngOnInitcallsloadRegistrarWorklist()— readsservicePointIDfrom session storage, maps the worklist records to the table row shape (restructWorklist), and populates the table. Failures stay silent (falls back to the usual empty table).Why
QA reported that previously registered beneficiaries were not visible on the registration page. (The old MMU-UI behaved the same — search-only, never auto-listed — so this is a new enhancement, agreed with the mentor.)
This depends on the backend
registrar/registrarWorkListDataendpoint, which is currently broken: it returnsTable 'db_iemr.i_beneficiary' doesn't exist(beneficiary data moved to the Identity service, so that legacy query is orphaned). The UI is complete and verified to call the endpoint correctly, but the list will only render once the backend endpoint is fixed to read beneficiaries by service point from the Identity source.Paired PR
Requires the matching MMU-UI PR that adds the
registrarWorkListDataUrlenvironment endpoint and bumps this Common-UI pointer.