fix for 1585, 1583

[snehar-nd]

📋 Description

JIRA ID:

AMM-1585
AMM-1583

Please provide a summary of the change and the motivation behind it. Include relevant context and details.

---

✅ Type of Change

• 🐞 Bug fix (non-breaking change which resolves an issue)

Summary by CodeRabbit

• Style

  • Improved layout and spacing in the quick consult component for a more consistent user interface.

• New Features

  • Enhanced inventory navigation by ensuring the facility ID is now included when accessing inventory from the pharmacist worklist.

[coderabbitai]

Walkthrough

The changes update the layout and styling in the quick consult component's HTML, adjust the method signature of moveToInventory in InventoryService to accept a facility ID, and update its usage in the pharmacist worklist component to pass this new parameter. No logic or control flow is altered.

Changes

File(s)	Change Summary
src/app/app-modules/nurse-doctor/quick-consult/quick-consult.component.html	Updated CSS classes for input fields and container divs; adjusted column class logic for layout.
src/app/app-modules/core/services/inventory.service.ts	Modified moveToInventory to accept and use a facilityID parameter; added console log.
src/app/app-modules/pharmacist/worklist/worklist.component.ts	Updated call to moveToInventory to include facility ID from session storage as an extra argument.

Possibly related PRs

• Fix for AMM-1585, AMM-1590, AMM-1591, AMM-1592 #185: Adds the input-full-width class to mat-form-field elements in the quick-consult component for consistent styling, which is directly related to similar changes in this PR.

Poem

A bunny hops through code so neat,
Adjusting widths and classes sweet.
Facility IDs now travel along,
As pharmacists sing a storage song.
With every hop, the UI grows bright—
Layouts and logic, working right!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-07-10T10_03_51_357Z-debug-0.log

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e5c8fa7 and b204e1d.

📒 Files selected for processing (4)

• src/app/app-modules/nurse-doctor/quick-consult/quick-consult.component.html (3 hunks)
• src/environments/environment.ci.ts.template (2 hunks)
• src/environments/environment.dev.ts (1 hunks)
• src/environments/environment.prod.ts (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

src/app/app-modules/nurse-doctor/quick-consult/quick-consult.component.html (2)

Learnt from: devikasuresh20
PR: PSMRI/MMU-UI#159
File: src/app/app-modules/nurse-doctor/vitals/general-patient-vitals/general-patient-vitals.component.html:604-606
Timestamp: 2024-12-04T10:52:54.401Z
Learning: In `src/app/app-modules/nurse-doctor/vitals/general-patient-vitals/general-patient-vitals.component.html`, when implementing conditional logic, prefer to clearly separate conditions for better readability, even if it introduces some redundancy.

Learnt from: devikasuresh20
PR: PSMRI/MMU-UI#153
File: src/app/app-modules/nurse-doctor/vitals/general-patient-vitals/general-patient-vitals.component.ts:325-337
Timestamp: 2024-11-28T06:19:38.920Z
Learning: In `general-patient-vitals.component.ts`, within the `checkNurseRequirements` method, the BP validation logic is intentionally specific to each flow to ensure clarity. Refactoring this logic is planned for future broader improvement efforts.

🔇 Additional comments (6)

src/app/app-modules/nurse-doctor/quick-consult/quick-consult.component.html (3)

375-375: Good consistency improvement.

Adding the input-full-width class ensures consistent styling with other form fields in the vitals section.

---

414-414: Good removal of inline styles.

Removing the inline margin-left style improves maintainability and follows CSS best practices by relying on responsive column classes.

---

857-862: Layout adjustment looks good.

The column width changes provide better spacing for the route selection field. The logic appropriately adjusts based on form type to accommodate different prescription layouts.

src/environments/environment.ci.ts.template (2)

40-40: Template variable change noted.

The change from <%= INVENTORY_UI_BASE %> to <%= INVENTORY_UI %> aligns with the URL path simplification. Ensure that the deployment pipeline is updated to provide the correct template variable.

---

61-61: Consistent URL path change.

The inventory URL modification matches the pattern used in other environment files, maintaining consistency across deployment environments.

src/environments/environment.prod.ts (1)

77-77: Production URL change matches other environments.

The inventory URL modification is consistent with the changes in dev and CI environments. Ensure that production deployment is coordinated with any necessary infrastructure changes to support the new URL structure.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b204e1d and f87ca2e.

📒 Files selected for processing (2)

• src/app/app-modules/core/services/inventory.service.ts (2 hunks)
• src/app/app-modules/pharmacist/worklist/worklist.component.ts (1 hunks)

🧰 Additional context used

🧠 Learnings (3)

📓 Common learnings

Learnt from: devikasuresh20
PR: PSMRI/MMU-UI#153
File: src/app/app-modules/nurse-doctor/vitals/general-patient-vitals/general-patient-vitals.component.ts:325-337
Timestamp: 2024-11-28T06:19:38.920Z
Learning: In `general-patient-vitals.component.ts`, within the `checkNurseRequirements` method, the BP validation logic is intentionally specific to each flow to ensure clarity. Refactoring this logic is planned for future broader improvement efforts.

src/app/app-modules/pharmacist/worklist/worklist.component.ts (1)

Learnt from: devikasuresh20
PR: PSMRI/MMU-UI#153
File: src/app/app-modules/nurse-doctor/vitals/general-patient-vitals/general-patient-vitals.component.ts:325-337
Timestamp: 2024-11-28T06:19:38.920Z
Learning: In `general-patient-vitals.component.ts`, within the `checkNurseRequirements` method, the BP validation logic is intentionally specific to each flow to ensure clarity. Refactoring this logic is planned for future broader improvement efforts.

src/app/app-modules/core/services/inventory.service.ts (1)

Learnt from: devikasuresh20
PR: PSMRI/MMU-UI#153
File: src/app/app-modules/nurse-doctor/vitals/general-patient-vitals/general-patient-vitals.component.ts:325-337
Timestamp: 2024-11-28T06:19:38.920Z
Learning: In `general-patient-vitals.component.ts`, within the `checkNurseRequirements` method, the BP validation logic is intentionally specific to each flow to ensure clarity. Refactoring this logic is planned for future broader improvement efforts.

🔇 Additional comments (3)

src/app/app-modules/core/services/inventory.service.ts (2)

44-46: LGTM: Method signature enhancement with proper fallback logic.

The addition of regID and facilityID parameters enhances the method's flexibility while maintaining backward compatibility through the fallback logic on line 48.

---

48-48: Good implementation: Proper fallback for facility ID.

The fallback logic facilityID || this.getFacilityID() appropriately handles cases where no facility ID is explicitly provided, ensuring backward compatibility.

src/app/app-modules/pharmacist/worklist/worklist.component.ts (1)

241-243: LGTM: Method call updated correctly to match service changes.

The addition of beneficiary.beneficiaryRegID and sessionStorage.getItem('facilityID') as arguments correctly aligns with the updated moveToInventory method signature. The service method's fallback logic will handle cases where the facility ID from session storage is null or undefined.