Skip to content

fix: remove console statements and duplicate tsconfig property in MMU-UI#344

Merged
snehar-nd merged 3 commits into
PSMRI:mainfrom
Aarti-panchal01:fix/duplicate-tsconfig-property
May 14, 2026
Merged

fix: remove console statements and duplicate tsconfig property in MMU-UI#344
snehar-nd merged 3 commits into
PSMRI:mainfrom
Aarti-panchal01:fix/duplicate-tsconfig-property

Conversation

@Aarti-panchal01
Copy link
Copy Markdown
Contributor

📋 Description

Code quality cleanup for MMU-UI production codebase.

Related to PSMRI/AMRIT#130 (C4GT DMP 2026)

✅ Type of Change

  • 🐞 Bug fix
  • ⚙️ Config change
  • 🚀 Performance
  • 🧹 Chore

ℹ️ Additional Information

Changes:

  • Removed 21 console.log/console.error statements from 5 production components
  • Removed duplicate noImplicitReturns property in tsconfig.json

Files: captcha.component.ts, workarea.component.ts, reset-password.component.ts, set-security-questions.component.ts, main.ts, tsconfig.json

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 12, 2026

Warning

Rate limit exceeded

@Aarti-panchal01 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 17 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d679c194-2b8a-4d7b-8c20-7e91b27435b1

📥 Commits

Reviewing files that changed from the base of the PR and between 91045e5 and 0c468c7.

📒 Files selected for processing (6)
  • src/app/app-modules/captcha/captcha.component.ts
  • src/app/app-modules/data-sync/workarea/workarea.component.ts
  • src/app/app-modules/reset-password/reset-password.component.ts
  • src/app/app-modules/set-security-questions/set-security-questions.component.ts
  • src/main.ts
  • tsconfig.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@Aarti-panchal01
Copy link
Copy Markdown
Contributor Author

Hi @drtechie,

While exploring the MMU-UI codebase to prepare for the Angular 16→19
migration (AMRIT#130), I noticed these console statements scattered across
authentication and data-sync components — particularly in workarea.component.ts
which will need significant refactoring during the migration anyway.

Cleaned them up proactively so the migration starts with a cleaner baseline.
Also caught the duplicate noImplicitReturns in tsconfig while reviewing
compiler options for Angular 19 compatibility.

One question while I have your attention - for the migration, should the
nurse-doctor module (108 components) be ported module-by-module in parallel
streams, or sequentially starting from the core module? The workarea.component.ts
at 3,762 lines seems like the highest-risk decomposition.

Happy to discuss approach in my proposal.

@snehar-nd snehar-nd merged commit a3ad862 into PSMRI:main May 14, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants