fix(core): remove console.log and console.info statements from core components#359
Conversation
|
Warning Review limit reached
Your plan currently allows 1 review/hour. Refill in 57 minutes and 49 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (12)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @snehar-nd @drtechie, this removes 36 debug console statements from core components, continuing the cleanup from #343/#344. Related to PSMRI/AMRIT#130 (C4GT DMP 2026). |
| () => { | ||
| console.log('completed'); | ||
| } | ||
| () => {}, |
There was a problem hiding this comment.
Silently ignoring errors is not considered a good practice for applications.
It is hard to debug sometimes.
@Kaushik-Kumar-CEG
There was a problem hiding this comment.
You're right — replaced with console.error(err) so errors are still visible for debugging. Fixed in latest push.
Kaushik-Kumar-CEG
force-pushed
the
fix/remove-console-core-components
branch
from
0b9f39e to
f593c1c
Compare
|
2 participants
📋 Description
Removes debug
console.logandconsole.infostatements from 12 core component files.console.errorcalls are retained where they serve as legitimate error reporting.Continues the cleanup started in #343/#344.
✅ Type of Change
ℹ️ Additional Information
Files cleaned (12):
allergen-search.component.ts(1 statement)app-footer.component.ts(1 statement)app-header.component.ts(5 statements)calibration.component.ts(2 statements)camera-dialog.component.ts(6 statements)data-sync-login.component.ts(1 statement)iot-bluetooth.component.ts(2 statements + 1 unused variable)iotcomponent.component.ts(9 statements)open-previous-visit-details.component.ts(4 statements)previous-details.component.ts(1 statement)provisional-search.component.ts(1 statement)set-language.component.ts(2 statements)Total: 36 debug statements removed. Zero behavior change.