🩹 [Patch]: Update argument completer to support Get-Font - #36
Merged
Conversation
Marius Storhaug (MariusStorhaug)
requested a review
from a team
as a code owner
February 13, 2025 12:42
Marius Storhaug (MariusStorhaug)
temporarily deployed
to
github-pages
February 14, 2025 07:44 — with
GitHub Actions
Inactive
|
Module Fonts - v1.1.14 published to the PowerShell Gallery. |
|
GitHub release for Fonts v1.1.14 has been created. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes changes to the PowerShell scripts for font management. The most important changes involve the consolidation of argument completers and the removal of redundant code.
Consolidation of argument completers:
src/functions/completers.ps1: Added a new argument completer for theUninstall-FontandGet-Fontcommands to handle theNameparameter. This script block checks theScopeparameter and filters font names based on the user's input.Removal of redundant code:
src/functions/public/Uninstall-Font.ps1: Removed the previously defined argument completer for theUninstall-Fontcommand, as it has been consolidated into the new script block incompleters.ps1.Type of change
Checklist