-
Notifications
You must be signed in to change notification settings - Fork 74
Add onDocumentSaved event for the UI Component #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
| @import PSPDFKit; | ||
| @import PSPDFKitUI; | ||
|
|
||
| @interface RCTPSPDFKitViewManager() <PSPDFDocumentDelegate> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RCTPSPDFKitViewManager doesn't need to conform to PSPDFDocumentDelegate, since RCTPSPDFKitView handles this, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct! Nice catch! Addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this will not touch windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for Android too 👍
ba0fc8e to
2a6e5b6
Compare
The iOS implementation of #82
How to test
yarn add github:PSPDFKit/react-native#rad/js-events-iosApp.jsWhat to test: