[WIP] Add additional callbacks to Android #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidschreiber
approved these changes
Jul 24, 2018
| } | ||
|
|
||
| private static List<Object> toList(JSONArray array) throws JSONException { | ||
| List<Object> list = new ArrayList<>(); |
There was a problem hiding this comment.
Could be already initialized at the correct size.
| * Converts the given {@link JSONObject} to a {@link Map}. | ||
| */ | ||
| public static Map<String, Object> jsonObjectToMap(JSONObject object) throws JSONException { | ||
| Map<String, Object> map = new HashMap<>(); |
There was a problem hiding this comment.
Could be already initialized at the correct size.
| this.fragmentManager = fragmentManager; | ||
| this.eventDispatcher = eventDispatcher; | ||
|
|
||
| pdfViewDocumentListener = new PdfViewDocumentListener(this, |
There was a problem hiding this comment.
Why the extra line break?
# Conflicts: # index.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android implementation for #90, #81, #88, #85
onDocumentSavedcallback.onAnnotationTappedcallback anddisableDefaultActionForTappedAnnotations.onAnnotationsChangedcallback.addedandchangedevent provide the full instant json,removedevent provides justnameandcreatorNamesince we can't get the instant json for detached annotations.saveCurrentDocumentwhich instantly saves the currently displayed document.