Skip to content
This repository was archived by the owner on Mar 17, 2021. It is now read-only.

Add GCC7 to build scripts and docs#452

Merged
dagar merged 2 commits intoPX4:masterfrom
hamishwillee:new_gcc
Feb 7, 2018
Merged

Add GCC7 to build scripts and docs#452
dagar merged 2 commits intoPX4:masterfrom
hamishwillee:new_gcc

Conversation

@hamishwillee
Copy link
Copy Markdown
Collaborator

@hamishwillee hamishwillee commented Feb 6, 2018

@dagar Thought it best to update the GCC to 7 as soon as possible - in response to PX4/PX4-Autopilot#8773 (comment)

Some questions inline though would appreciate your help with.

@hamishwillee hamishwillee requested a review from dagar February 6, 2018 11:20
Comment thread build_scripts/ubuntu_sim_nuttx.sh Outdated
sudo apt-get update
sudo apt-get install libc6:i386 libgcc1:i386 libstdc++5:i386 libstdc++6:i386 -y
sudo apt-get install gcc-5.4-base:i386 -y
sudo apt-get install gcc-7.3-base:i386 -y
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dagar This is an incorrect guess. What do I use for the 32 bit libraries?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this package exists, however we don't have to have the regular gcc version with the arm-none-eabi-gcc version.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, as we discussed I will delete all the 32bit support libraries.

Comment thread en/setup/dev_env_linux_centos.md Outdated

```sh
bash: gcc-arm-none-eabi-4_7-2014q2/bin/arm-none-eabi-gcc: /lib/ld-linux.so.2: bad ELF interpreter: No such file or directory
bash: gcc-arm-none-eabi-4_7-2014q2/bin/arm-none-eabi-gcc: /lib/ld-linux.so.2: bad ELF interpreter: No such file or directory
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dagar I can imagine that I could replace the source path to the current gcce - e.g. with something like:

gcc-arm-none-eabi-7-2017-q4-major/bin/arm-none-eabi-gcc: /lib/ld-linux.so.2: bad ELF interpreter: No such file or directory 

But how can I tell if this is still valid?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I delete the support libraries above then this won't be needed because it is only relevant to them.

```sh
sudo apt-get install libc6:i386 libgcc1:i386 libstdc++5:i386 libstdc++6:i386
sudo apt-get install gcc-4.6-base:i386
sudo apt-get install gcc-7.3-base:i386
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, needs to be correct 32 bit binaries

<!-- import GCC toolchain common documentation -->
{% include "_gcc_toolchain_installation.txt" %}

## Additional 32 bit libraries
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, removed these instructions - 32 bit support libraries as we discussed.


Now restart your machine.
<!-- import GCC toolchain common documentation -->
{% include "_gcc_toolchain_installation.txt" %}
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This imports same instructions as every other build. We can do this now that the 32 bit support libraries are no longer required.

This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
```

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this section as it makes no sense now the 32bit support libraries are not needed. Actually the whole section technically isn't needed since it no longer provides any real troubleshooting - however telling people how to check versions is always useful step in debuggin.

@hamishwillee
Copy link
Copy Markdown
Collaborator Author

This is ready for re-review.

@dagar dagar merged commit 9005d31 into PX4:master Feb 7, 2018
@hamishwillee hamishwillee deleted the new_gcc branch February 7, 2018 05:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants