fix(docs): move screenshot to public/ so it deploys#83
Merged
Conversation
VitePress emits fingerprinted bundle output into /assets/ at the site root, so a static file at docs/assets/screenshot.png never gets copied to the dist. Move it to docs/public/ which VitePress publishes verbatim, and update the hero, logo, and README references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The landing page and README referenced
docs/assets/screenshot.png, but VitePress emits its own fingerprinted bundle output into/assets/at the site root, so a static file underdocs/assets/never gets copied into thedist/output. That's whyhttps://px4.github.io/Hawkeye/assets/screenshot.pngis 404'ing on the live site.Moves the file to
docs/public/screenshot.png(VitePress publishes everything underpublic/verbatim), and updates the hero image path indocs/index.md, the sidebar logo indocs/.vitepress/config.ts, and the README reference. The README continues to render the image correctly because GitHub resolves relative paths against the repo.After merge and the next Pages deploy, the hero image will resolve at
https://px4.github.io/Hawkeye/screenshot.png.