[CI] Fix nightly test error and add container cleanup in build_rl#7335
Merged
EmmonsCurse merged 2 commits intoPaddlePaddle:developfrom Apr 11, 2026
Merged
[CI] Fix nightly test error and add container cleanup in build_rl#7335EmmonsCurse merged 2 commits intoPaddlePaddle:developfrom
EmmonsCurse merged 2 commits intoPaddlePaddle:developfrom
Conversation
Collaborator
Author
|
/skip-ci all |
|
Thanks for your contribution! |
fastdeploy-bot
left a comment
There was a problem hiding this comment.
🤖 AI Code Review |
2026-04-11
📋 Review 摘要
PR 概述:修复 nightly 测试错误,移除 --privileged 增强安全性,新增容器清理逻辑
变更范围:CI workflow 配置(.github/workflows/)
影响面 Tag:[CI]
PR 规范检查
PR 标题和描述符合规范:
- ✅ 标题包含有效标签
[CI] - ✅ 描述完整填写了 Motivation 和 Modifications 章节
发现的问题
| 级别 | 文件 | 概述 |
|---|---|---|
| 🟡 建议 | .github/workflows/_build_linux_rl.yml:142 |
--shm-size=64G 大小写与 _accuracy_test.yml 中的 64g 不统一 |
总体评价
PR 变更整体合理:
- 移除
--privileged减少安全风险,保留必要的--cap-add=SYS_PTRACE - 新增
--sysctl参数增加 IPC 消息队列容量,与测试 workflow 保持一致 - 新增容器清理逻辑与项目现有实践一致
唯一的小问题是 --shm-size 单位大小写不统一(64G vs 64g),建议保持一致性。
| echo "PARENT_DIR:$PARENT_DIR" | ||
| docker run --rm --net=host \ | ||
| --cap-add=SYS_PTRACE --privileged --shm-size=64G \ | ||
| --cap-add=SYS_PTRACE --shm-size=64G \ |
There was a problem hiding this comment.
🟡 建议 --shm-size=64G 与本 PR 中 _accuracy_test.yml 的 64g 大小写不一致。
建议统一使用小写单位(64g)以保持一致性。
EmmonsCurse
added a commit
to EmmonsCurse/FastDeploy
that referenced
this pull request
Apr 11, 2026
5 tasks
EmmonsCurse
added a commit
to EmmonsCurse/FastDeploy
that referenced
this pull request
Apr 11, 2026
5 tasks
EmmonsCurse
added a commit
that referenced
this pull request
Apr 12, 2026
EmmonsCurse
added a commit
to EmmonsCurse/FastDeploy
that referenced
this pull request
Apr 12, 2026
5 tasks
EmmonsCurse
added a commit
that referenced
this pull request
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
--privilegedusage.Modifications
sysctlparameters to ensure sufficient system resource limits for model inference and multiprocessing workloads.--privilegedfrom Docker execution:--privilegedmay be restricted.build_rlto avoid leftover containers affecting subsequent jobs.Usage or Command
N/A
Accuracy Tests
N/A
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.