[Cherry-Pick][CI] Sync dev optimizations to 2.4(#7335)#7346
[Cherry-Pick][CI] Sync dev optimizations to 2.4(#7335)#7346EmmonsCurse merged 5 commits intoPaddlePaddle:release/2.4from
Conversation
|
Thanks for your contribution! |
|
/skip-ci gpu_4cards_test |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/2.4 #7346 +/- ##
==============================================
Coverage ? 56.43%
==============================================
Files ? 333
Lines ? 42621
Branches ? 6478
==============================================
Hits ? 24052
Misses ? 16699
Partials ? 1870
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fastdeploy-bot
left a comment
There was a problem hiding this comment.
🤖 AI Code Review | 2026-04-12
📋 Review 摘要
PR 概述:将 dev 分支的 CI 优化(容器清理、环境变量配置、pip 安装优化)cherry-pick 到 release/2.4 分支。
变更范围:.github/workflows/(多个 CI 配置文件)、scripts/run_pre_ce.sh、测试文件
影响面 Tag:[CI]
📝 PR 规范检查
问题:PR 标题使用了 [Cherry-Pick] 标签,但这不是官方标签列表中的标签。
根据官方标签列表,有效的 CI 相关标签是 [CI]。虽然 Cherry-Pick 是特殊的合并流程,但建议标题只使用官方标签,可以在描述中说明这是 cherry-pick 的变更。
标题建议(可直接复制):
[CI] Sync dev optimizations to 2.4 (#7335)
问题
| 级别 | 文件 | 概述 |
|---|---|---|
| 🟡 建议 | tests/ce/server/core/utils.py:29 |
send_request 默认 timeout 从 600 秒改为 60 秒,影响范围较大 |
总体评价
CI 优化整体合理,增强了容器清理机制防止资源泄漏,添加了必要的环境变量和内核参数配置。但 timeout 默认值的变更需要评估其对现有测试的影响。
|
|
||
|
|
||
| def send_request(url, payload, timeout=600, stream=False): | ||
| def send_request(url, payload, timeout=60, stream=False): |
There was a problem hiding this comment.
🟡 建议 将 send_request 的默认 timeout 从 600 秒改为 60 秒,这是 10 倍的减少。
影响分析:
- 多个测试文件(如
test_stream.py、test_base_chat.py等)调用了send_request而没有指定 timeout 参数,都会使用这个默认值 - 60 秒可能不足以处理某些需要长时间响应的请求
建议:
- 评估现有测试的超时需求
- 如需调整,建议逐步调整或在关键测试中显式指定 timeout
Motivation
The CI pipeline may leave behind running containers or uncleaned workspaces when jobs are canceled or fail unexpectedly. This can cause resource leakage, workspace conflicts, and instability in subsequent jobs.
Modifications
Cherry-pick of #7198 #7227 #7283 #7268 #7315 #7335 to
release/2.4.Usage or Command
N/A
Accuracy Tests
N/A
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.