[pull] master from angular:master#377
Merged
pull[bot] merged 7 commits intoPandinosaurus:masterfrom Oct 2, 2019
Merged
Conversation
…mode (#32955) Similarly to `ts_library` compilation actions, the `ng_module` compile action should include the current compile mode in the action description. This makes it consistent with `ts_library` targets and also avoids confusion when both output flavors are requested. Currently when both output flavors are requested (e.g. in the `ng_package` rule), both devmode and prodmode compilations have the same action name. This is confusing and looks like the given target is built *twice* due to a bug (which is obviously not the case though) PR Close #32955
Angular uses tslint:recommended by default. The default for no-angle-bracket-type-assertion is true See https://github.com/palantir/tslint/blob/master/src/configs/recommended.ts#L69 PR Close #31042
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )