Skip to content

feat(clients): optional billing email for invoicing + copy/toggle password buttons - #17

Merged
Panelica merged 5 commits into
Panelica:mainfrom
hedon77:feat/client-billing-email
Sep 3, 2026
Merged

feat(clients): optional billing email for invoicing + copy/toggle password buttons#17
Panelica merged 5 commits into
Panelica:mainfrom
hedon77:feat/client-billing-email

Conversation

@hedon77

@hedon77 hedon77 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Adds an optional per-client billing (accounting) email address, separate from the sign-in address.

  • New \clients.billing_email\ column + \Client::billingEmail()\ helper (falls back to the account email).
  • Editable from admin client create/edit and the client profile.
  • Invoice and payment-reminder emails now deliver to \�illingEmail()\ (manual send, bulk, events, cron).
  • Shown in the client information panel.
  • Adds copy + show/hide buttons to the admin password generator (matching the client area).

@Panelica

Copy link
Copy Markdown
Owner

Thorough — you found every billing send site. Please double-check that common.copy / common.toggle exist as translation keys (the button titles reference them). Otherwise good; we'll rebase this after #14.

@hedon77

hedon77 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

Confirmed — common.copy and common.toggle both exist in lang/en/common.php and lang/pl/common.php.

@Panelica

Panelica commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Thank you — this was thorough; you found every billing send-site. We just merged the first clean batch into main: #16 (client delete), #24 (invoice number display), #13 (Tpay), #22 (addon settings framework) and #14 (tax rewrite). #14 (tax) and #16 (client delete) overlap this on the invoice and client files, so it now needs a rebase on the updated main. Once it's green again we'll merge. Much appreciated.

@hedon77
hedon77 force-pushed the feat/client-billing-email branch from 1f833cc to bd7ef54 Compare September 1, 2026 19:39
@hedon77

hedon77 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

*Zrebasowane na aktualny \main* — gałąź merguje się teraz czysto, konflikt zniesiony. Gotowe do merga.

@Panelica

Panelica commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Thank you — this is good work, and it's safe by design (billing_email is optional and falls back to the account address). We just merged #9 and #21, which overlap this on the invoice and client files, so GitHub now shows a conflict. A rebase on the updated main and we'll merge it. Appreciated.

@hedon77
hedon77 force-pushed the feat/client-billing-email branch from bd7ef54 to 55d5a38 Compare September 2, 2026 15:39
@hedon77

hedon77 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

*Zrebasowane na aktualny \main* (po zmergowaniu #9/#21) — konflikt zniesiony, gałąź merguje się czysto. Gotowe do merga.

@Panelica
Panelica merged commit e192f85 into Panelica:main Sep 3, 2026
1 check passed
Panelica pushed a commit that referenced this pull request Sep 3, 2026
The zh files had drifted from English after several merges (#9, #14, #17, #21,
#23): same keys, but flattened/reordered, so the zh structure test failed.
Rebuild admin/client/common/messages to English's exact nesting and order,
keeping every existing Chinese translation. Also fix funds.amount_range, which
carried :min/:max placeholders English does not pass, so it rendered the raw
tokens; it now matches the English static form.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants