fix: mock chain provider gas estimation in backend tests - #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing
getProvider().estimateGas()mocks to backend tests that mock the chain provider.The production code now performs gas estimation through the chain provider, but several existing tests only mocked
getContract(). This allowed the tests to fall through into provider behaviour that should not be exercised by unit and integration fixtures.The updated mocks return a deterministic gas estimate of
100000n.Scope
Test fixtures only. No production execution logic is changed.
Updated coverage includes:
Verification
npm ci: passedgit diff --check: passed