fix: avoid invalid gas estimation for dependent bundle steps - #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Multi-step execution bundles were estimating gas for every step independently against the current chain state.
For sequential bundles such as:
the second transaction depends on state created by the first transaction. Estimating the swap before the approval has executed can therefore revert even though the complete bundle is valid when executed sequentially.
This was observed on the Avalanche TraderJoe swap flow as
TransferFromFailed (0x7939f424)during bundle preparation.Fix
Gas estimation now respects sequential bundle dependencies:
Verification
Full backend test suite:
Live local Avalanche preparation test:
TransferFromFailed / 0x7939f424during preparationThis preserves gas estimation where it is valid while preventing preparation from failing on transactions whose preconditions are established by earlier bundle steps.