Backport some stuff from the generators branch#10365
Merged
Machine-Maker merged 1 commit intoPaperMC:masterfrom Apr 6, 2024
Merged
Backport some stuff from the generators branch#10365Machine-Maker merged 1 commit intoPaperMC:masterfrom
Machine-Maker merged 1 commit intoPaperMC:masterfrom
Conversation
kennytv
approved these changes
Mar 28, 2024
Member
|
I would deprecate |
lynxplay
approved these changes
Apr 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport some relevant stuff from the generators branch that fit into the main branch
PinkPetals#getMinimumFlowerAmount, like MachineMaker said in the original PR any int property that doesn't start from zero should have a minimum method (exception is the composter caused by the levelled interface).MemoryKey#SNIFFER_EXPLORED_POSITIONS, this key use the wrong generic type and will (once the sniffer already have a memory key) throw an error on the getter, and corrupt the nbt data on the setter