Improve Riptide API#10788
Closed
PlayerSchark wants to merge 2 commits into
Closed
Conversation
PlayerSchark
force-pushed
the
feature/Improve-Riptide-API
branch
from
c390d95 to
b886a8e
Compare
maxcom1
suggested changes
May 26, 2024
Contributor
maxcom1
left a comment
maxcom1
left a comment
There was a problem hiding this comment.
Hi, thanks for the contribution!
I've highlighted a couple of lines that should be corrected - I recommend reading the contribution guide :>
I think this patch could also be merged into the 'Improve Projectile API' patch, but wait for the team to decide
PlayerSchark
force-pushed
the
feature/Improve-Riptide-API
branch
3 times, most recently
from
3951679 to
1084a78
Compare
Author
|
I fixed the imports |
PlayerSchark
force-pushed
the
feature/Improve-Riptide-API
branch
from
1084a78 to
7e6234d
Compare
PlayerSchark
force-pushed
the
feature/Improve-Riptide-API
branch
from
7e6234d to
683001c
Compare
kennytv
added
the
pre-softspoon: never rebased
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found the PR #5753 which is about improving the Riptide API. The PR seems to be outdated so I updated it and fixed a trident issue which was mentioned in the PR.
I also added the option to control the riptide sound in PlayerRiptideEvent.
Maybe close #5753 ?