Improve Riptide API#5753
Closed
Machine-Maker wants to merge 1 commit into
Closed
Conversation
Machine-Maker
force-pushed
the
feature/Riptide-API
branch
from
2712a32 to
32bbde2
Compare
Machine-Maker
force-pushed
the
feature/Riptide-API
branch
from
32bbde2 to
4d00260
Compare
ghost
approved these changes
Jun 2, 2021
electronicboy
approved these changes
Jun 5, 2021
MiniDigger
approved these changes
Jun 5, 2021
Member
MiniDigger
left a comment
MiniDigger
left a comment
There was a problem hiding this comment.
A bit weird that we have to do this so high up in the inheritance tree even tho not many entities actually support this, but I don't know a much nicer solution either. Lgtm
Member
Author
|
Actually, most of the entities I did try worked fine @MiniDigger |
Member
|
ah ok, then the javadoc did threw me up, all good then |
kennytv
force-pushed
the
feature/Riptide-API
branch
from
4d00260 to
9c6559f
Compare
kennytv
force-pushed
the
feature/Riptide-API
branch
from
9c6559f to
d2d462e
Compare
kennytv
requested changes
Jun 8, 2021
Member
kennytv
left a comment
kennytv
left a comment
There was a problem hiding this comment.
You didn't pass the animation ticks into the event constructor, so I fixed that, something (your own animation when using a trident with riptide) is still bork tho. Plz fix
Closed
kennytv
added
the
pre-softspoon: never rebased
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out the animation part of the event is controlled by the server, the jump part isn't.
You can have a lot of fun with this since its on LivingEntity.
simplescreenrecorder-2021-05-29_20.07.57.mp4
simplescreenrecorder-2021-05-29_20.29.36.mp4