Fix bundled spark permission check#11355
Merged
Merged
Conversation
Machine-Maker
approved these changes
Sep 2, 2024
lynxplay
approved these changes
Sep 6, 2024
LeonTG
pushed a commit
to LeonTG/Paper
that referenced
this pull request
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue reported in lucko/spark#444
A brief summary is that currently, the bundled spark command is not registered unless the sender has the "spark" permission, whereas it should be registered if the sender has the base "spark" wildcard permission or permission for any of the spark sub-commands.
The fix uses the same approach as the built-in
/papercommand, using;as delimiter:Paper/patches/server/0017-Paper-command.patch
Line 193 in b483da4
We could alternatively override the
testPermissionSilent()method inorg.bukkit.Command, but I thought the first option would be preferable.Related commit in spark lucko/spark@55b3839