Skip to content

Fix PlayerTrade/PurchaseEvent visual issue when being cancelled#11730

Closed
HaHaWTH wants to merge 1 commit into
PaperMC:masterfrom
HaHaWTH:fix/player-trade-event
Closed

Fix PlayerTrade/PurchaseEvent visual issue when being cancelled#11730
HaHaWTH wants to merge 1 commit into
PaperMC:masterfrom
HaHaWTH:fix/player-trade-event

Conversation

@HaHaWTH
Copy link
Copy Markdown
Contributor

@HaHaWTH HaHaWTH commented Dec 11, 2024

This pull request fixes #11693.

Changes made

Fixes client-side visual issues when cancelling PlayerTradeEvent/PlayerPurchaseEvent by resending merchant offer packets.

To reproduce

Make a plugin that cancels PlayerTradeEvent like this code snippet:

@EventHandler
 public void onPlayerTrade(PlayerTradeEvent event) {
      event.setCancelled(true);
      event.setRewardExp(false);
      event.setIncreaseTradeUses(false);
 }

@HaHaWTH HaHaWTH requested a review from a team as a code owner December 11, 2024 19:10
@HaHaWTH HaHaWTH changed the title Fix PlayerTradeEvent visual issue when being cancelled Fix PlayerTrade/PurchaseEvent visual issue when being cancelled Dec 12, 2024
@HaHaWTH HaHaWTH closed this Dec 22, 2024
@HaHaWTH HaHaWTH deleted the fix/player-trade-event branch December 22, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

Cancelling PlayerTradeEvent levels up the villager and locks trades

2 participants