Skip to content

Fix PlayerTradeEvent/PlayerPurchase visual issue when being cancelled#11773

Merged
kennytv merged 1 commit into
PaperMC:mainfrom
HaHaWTH:hard-fork/fix/player-trade-event
Dec 23, 2024
Merged

Fix PlayerTradeEvent/PlayerPurchase visual issue when being cancelled#11773
kennytv merged 1 commit into
PaperMC:mainfrom
HaHaWTH:hard-fork/fix/player-trade-event

Conversation

@HaHaWTH
Copy link
Copy Markdown
Contributor

@HaHaWTH HaHaWTH commented Dec 22, 2024

This pull request fixes #11693.

Reopen #11730.

Changes made

Fixes client-side visual issues when cancelling PlayerTradeEvent/PlayerPurchaseEvent by resending merchant offer packets.
The value 1 here is for WanderingTrader and CustomMerchantMenu.

To reproduce

Make a plugin that cancels PlayerTradeEvent like this code snippet:

@EventHandler
 public void onPlayerTrade(PlayerTradeEvent event) {
      event.setCancelled(true);
      event.setRewardExp(false);
      event.setIncreaseTradeUses(false);
 }

@HaHaWTH HaHaWTH requested a review from a team as a code owner December 22, 2024 23:33
@kennytv kennytv merged commit 17f649d into PaperMC:main Dec 23, 2024
@HaHaWTH HaHaWTH deleted the hard-fork/fix/player-trade-event branch January 4, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

Cancelling PlayerTradeEvent levels up the villager and locks trades

3 participants