Add registry builders for SoundEvent and JukeboxSong#11805
Merged
Machine-Maker merged 4 commits intoPaperMC:dev/1.21.6from Jun 14, 2025
Merged
Conversation
Machine-Maker
force-pushed
the
feature/JukeboxSong-registry-builder
branch
3 times, most recently
from
d32f547 to
d4e8d54
Compare
Lulu13022002
reviewed
Jan 7, 2025
paper-api/src/main/java/io/papermc/paper/registry/data/JukeboxSongRegistryEntry.java
Outdated
Show resolved
Hide resolved
paper-server/src/main/java/io/papermc/paper/registry/data/util/Checks.java
Outdated
Show resolved
Hide resolved
paper-server/src/main/java/io/papermc/paper/registry/data/PaperJukeboxSongRegistryEntry.java
Outdated
Show resolved
Hide resolved
Machine-Maker
force-pushed
the
feature/JukeboxSong-registry-builder
branch
2 times, most recently
from
7b1f1ce to
f459030
Compare
Member
|
I think the Either should allow for non-optional use too, e.g. isLeft/Right and left/right that throw on incorrect use. right now I assume the idea is to use instanceof checks given the two extra interfaces are exposed, but I'd prefer (also having) methods on Either for that |
Contributor
|
Decided to go with Either, rename however to specific usecase (e.g. Holder instance, so .key() and .directValue or something). |
Machine-Maker
force-pushed
the
feature/JukeboxSong-registry-builder
branch
from
cff7787 to
7111513
Compare
Machine-Maker
force-pushed
the
feature/JukeboxSong-registry-builder
branch
from
406e3c5 to
36306ad
Compare
Machine-Maker
force-pushed
the
feature/JukeboxSong-registry-builder
branch
from
36306ad to
70927a3
Compare
Machine-Maker
force-pushed
the
feature/JukeboxSong-registry-builder
branch
from
70927a3 to
05453cd
Compare
github-project-automation
bot
moved this from Awaiting review
to Merged
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft until we decided thatEither it isEither<L, R>is the way to go for the fluent getter atJukeboxSongRegistryEntry#soundEvent