Add combat tracker API#11853
Merged
Merged
Conversation
kennytv
reviewed
Dec 29, 2024
lynxplay
reviewed
Feb 21, 2025
lynxplay
reviewed
Feb 21, 2025
lynxplay
reviewed
Feb 21, 2025
lynxplay
reviewed
Feb 21, 2025
lynxplay
reviewed
Feb 21, 2025
SoSeDiK
force-pushed
the
combat-tracker
branch
from
8e40f76 to
9112ad4
Compare
SoSeDiK
force-pushed
the
combat-tracker
branch
2 times, most recently
from
2b98777 to
404e6d6
Compare
kennytv
approved these changes
Feb 28, 2025
github-project-automation
Bot
moved this from Awaiting review
to Awaiting final testing
in Paper PR Queue
Warriorrrr
approved these changes
Mar 5, 2025
lynxplay
reviewed
Apr 22, 2025
lynxplay
force-pushed
the
combat-tracker
branch
from
75f81ff to
cc2d2ec
Compare
lynxplay
reviewed
Apr 22, 2025
lynxplay
moved this from Awaiting final testing
to PR Party candidate
in Paper PR Queue
- Rename FallLocation to FallLocationType - Change CombatTracker#getCombatEntries javadoc
lynxplay
force-pushed
the
combat-tracker
branch
from
bb7a922 to
0f3a0f8
Compare
lynxplay
approved these changes
Apr 30, 2025
github-project-automation
Bot
moved this from PR Party candidate
to Awaiting final testing
in Paper PR Queue
github-project-automation
Bot
moved this from Awaiting final testing
to Merged
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
LivingEntity#getCombatTrackerto get entity's combat tracker that allows getting/setting combat history (list of damage entries during a combat session), recording new combat entries without causing actual damage, getting/resetting current combat state/session and getting a death message based on the present combat history.FallLocationTyperepresents a location from which the entity fell, and is used by vanilla to generate fall death messages.API implementation is basically done, but definitely open to feedback. Javadocs & namings could use some love.