Skip to content

feat: add new message for velocity in online mode#11857

Closed
mja00 wants to merge 1 commit into
PaperMC:mainfrom
mja00:feat/velocity-offline-msg
Closed

feat: add new message for velocity in online mode#11857
mja00 wants to merge 1 commit into
PaperMC:mainfrom
mja00:feat/velocity-offline-msg

Conversation

@mja00
Copy link
Copy Markdown
Contributor

@mja00 mja00 commented Dec 29, 2024

Back in #8812 I added support for detecting if the end user is using Velocity over Bungeecord for the offline mode warning.

This expands upon that and will swap up the message whenever they're using Velocity in online mode. It's still enough of a message to let people know but without being a complete nag.

It'll also make it, so people are less confused when they see the message in server logs in the paper-help channel.

Definitely open to different wording on the message. I'm not really good at Englishing properly some days.

@mja00 mja00 requested a review from a team as a code owner December 29, 2024 02:03
@Leguan16
Copy link
Copy Markdown
Contributor

Do we even need a message like that. Like if they are using velocity online mode, can't we just say "Using Velocity for Authentication"?

@mja00
Copy link
Copy Markdown
Contributor Author

mja00 commented Dec 29, 2024

Do we even need a message like that. Like if they are using velocity online mode, can't we just say "Using Velocity for Authentication"?

Technically this server is still not authenticating usernames. It's just trusting Velocity's checks.

@MiniDigger
Copy link
Copy Markdown
Member

I have no idea about velocity, but is there a risk here? you can't bypass velocity like you can with bungee, right?
so the only risk is that you configured velocity incorrectly (i.e. not authenticating there) or you configured a velocity instance that you don't control, I don't think we need to tell the user to "beware" for that (especially without suggesting concrete actions)

@NonSwag
Copy link
Copy Markdown
Contributor

NonSwag commented Dec 29, 2024

One or two years ago we had a discussion about a different message and the outcome was how it is now (just the firewall link)
I dont think there is any change necessary

@electronicboy
Copy link
Copy Markdown
Member

The logic here is flawed and a bungee mode server in which a user has said velocity online to true would trip this message improperly; This is also generally not stuff that I see the need to throw time on

@mja00
Copy link
Copy Markdown
Contributor Author

mja00 commented Dec 29, 2024

Yeah after some thinking there's no real good way to convey all the decent information. I'll just close this up lol

@mja00 mja00 closed this Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

5 participants