feat: add new message for velocity in online mode#11857
Conversation
|
Do we even need a message like that. Like if they are using velocity online mode, can't we just say "Using Velocity for Authentication"? |
Technically this server is still not authenticating usernames. It's just trusting Velocity's checks. |
|
I have no idea about velocity, but is there a risk here? you can't bypass velocity like you can with bungee, right? |
|
One or two years ago we had a discussion about a different message and the outcome was how it is now (just the firewall link) |
|
The logic here is flawed and a bungee mode server in which a user has said velocity online to true would trip this message improperly; This is also generally not stuff that I see the need to throw time on |
|
Yeah after some thinking there's no real good way to convey all the decent information. I'll just close this up lol |
Back in #8812 I added support for detecting if the end user is using Velocity over Bungeecord for the offline mode warning.
This expands upon that and will swap up the message whenever they're using Velocity in online mode. It's still enough of a message to let people know but without being a complete nag.
It'll also make it, so people are less confused when they see the message in server logs in the paper-help channel.
Definitely open to different wording on the message. I'm not really good at Englishing properly some days.