Modify offline mode warning to include Velocity line#8812
Conversation
NoahvdAa
left a comment
NoahvdAa
left a comment
There was a problem hiding this comment.
This should go into the Velocity support patch
|
Time to figure out how to modify patches now. 👍🏻 |
mja00
force-pushed
the
feat/velocity-in-offline-mode-msg
branch
from
7298928 to
7ddca71
Compare
|
I think I did it correctly lol |
MiniDigger
left a comment
MiniDigger
left a comment
There was a problem hiding this comment.
that dos indeed look correct.
the branch requirement is so that the team can properly modify your branch, github prohibits that on master.
one thought I had is extracting the two variables (link and software) out so that the text isn't duplicated, but prolly not worth it so approving as it
|
I think if velocity forwarding + velocity online mode is enabled the warning should be hidden entirely |
|
This message feels weird given that velocity forwarding is much more secure than bungees; I also wouldn't mind if velocity online mode was an info message instead of a warn |
|
tbh the existing message for bungeecord is kinda bad too, might be a good idea to clean that up a bit as well |
|
If someone else figures out the wording I'd gladly swap it to that (I am not a wordsmith). Otherwise I can change up the if statement so we're not duplicating that one line and swap it to INFO if wanted. |
|
This latest change should be what Mini was suggesting I believe. Definitely makes it cleaner. I'm not too sure how to go about swapping to using INFO if online-mode for velocity is enabled. It seems like we'd be duplicating a lot of lines for that. Unless we just change that message entirely. |
Owen1212055
force-pushed
the
feat/velocity-in-offline-mode-msg
branch
from
b312862 to
a17eb57
Compare
Owen1212055
force-pushed
the
feat/velocity-in-offline-mode-msg
branch
from
2007721 to
aec9aa4
Compare
This adds a check to the offline-mode warning to see if Velocity is enabled. If it is enabled then it warns the user to make sure to secure their server and links to the Velocity documentation on that.
This adds a check to the offline-mode warning to see if Velocity is enabled. If it is enabled then it warns the user to make sure to secure their server and links to the Velocity documentation on that.
7 participants
This adds a check to the offline-mode warning to see if Velocity is enabled. If it is enabled then it warns the user to make sure to secure their server and links to the Velocity documentation on that.
Attempt 2 since I had no idea about the branch name requirement.