Add TrialSpawner methods for end of cooldown and next mob spawn time#12025
Merged
lynxplay merged 9 commits intoFeb 12, 2025
Merged
Conversation
lynxplay
requested changes
Jan 27, 2025
kennytv
approved these changes
Jan 31, 2025
Member
kennytv
left a comment
kennytv
left a comment
There was a problem hiding this comment.
Gametime -> game time and you could maybe add a @see tag for a method to get the game time, else looks good
Member
Author
|
based in others PR is valid implement jspecify in this classes or can be done in another PR? |
Member
|
Since you're already changing all method lines you might as well update the annotations here yeah 👍 add nullmarked at the top and remove the explicit notnull annotations |
…e/trial-spawner-state-more-methods # Conflicts: # paper-api/src/main/java/org/bukkit/block/TrialSpawner.java
Lulu13022002
reviewed
Feb 1, 2025
lynxplay
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolve #12023 by adding two new methods related to the when the cooldown ends in gametime and when the next mob spawn in gametime.
ref: https://minecraft.wiki/w/Trial_Spawner