Fix getForwards/SidewaysMovement for players#12140
Merged
lynxplay merged 3 commits intoFeb 18, 2025
Merged
Conversation
Warriorrrr
added
type: bug
lynxplay
approved these changes
Feb 17, 2025
Contributor
lynxplay
left a comment
lynxplay
left a comment
There was a problem hiding this comment.
Approved outside of the if branch styling.
Machine-Maker
approved these changes
Feb 17, 2025
Contributor
|
Maybe getUpwardsMovement could be overriden too for consistency even if the javadocs say otherwise. |
Contributor
|
Don't think we need to go further than sidewards/forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12139