Add FishHookStateChangeEvent to detect fishing hook state transitions.#12165
Merged
notTamion merged 6 commits intoMay 15, 2025
Merged
Conversation
Owen1212055
reviewed
Feb 23, 2025
Contributor
Author
|
After re-testing, I confirmed that everything works perfectly. If nothing has been overlooked, then this should be complete👍 hookeventtest.mp4 |
Warriorrrr
approved these changes
Feb 28, 2025
kennytv
approved these changes
Apr 22, 2025
721dbc0 to
5484cdf
Compare
notTamion
approved these changes
May 15, 2025
Contributor
Author
|
Hi notTamion! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
PlayerFishEventis not triggered when aFishHookchanges its state. This means that if you want to track state transitions, you have to monitor them using a scheduler, which is inefficient. To address this, I have implementedFishHookStateChangeEvent.Canceling the transition toHookState.BOBBINGpreventsMinecraft#FishingHook#catchingFishfrom executing.Be cautious when handling this event, as canceling it will not prevent the state transition from being re-evaluated in the next tick. If the conditions are still met, the event will be instantiated and called repeatedly. (This behavior is documented in the Javadoc.)Reverted due to spamming of events and desync with the client side.For consistency, this event is mostly copied from
PufferFishStateChangeEvent. However, I feel that "State Transition" might be a more appropriate term than "State Change."