-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add FishHookStateChangeEvent to detect fishing hook state transitions. #12165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
notTamion
merged 6 commits into
PaperMC:main
from
NamiUni:feat-fishing-hook-state-change-event
May 15, 2025
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e5dc262
Add FishHookStateChangeEvent.
NamiUni 919ae53
Implement Cancellable in FishHookStateChangeEvent.
NamiUni 7080247
Do not change the indentation.
NamiUni c8b1161
Cancel the implementation of Cancellable.
NamiUni 453ba57
Modify the FishingHook patch.
NamiUni 5484cdf
update and jd fixes
notTamion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
52 changes: 52 additions & 0 deletions
52
paper-api/src/main/java/io/papermc/paper/event/entity/FishHookStateChangeEvent.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| package io.papermc.paper.event.entity; | ||
|
|
||
| import org.bukkit.entity.FishHook; | ||
| import org.bukkit.event.HandlerList; | ||
| import org.bukkit.event.entity.EntityEvent; | ||
| import org.bukkit.event.player.PlayerFishEvent; | ||
| import org.jetbrains.annotations.ApiStatus; | ||
| import org.jspecify.annotations.NullMarked; | ||
|
|
||
| /** | ||
| * Called just before a {@link FishHook}'s {@link FishHook.HookState} is changed. | ||
| * | ||
| * <p>If you want to monitor a player's fishing state transition, you can use {@link PlayerFishEvent}.</p> | ||
| */ | ||
| @NullMarked | ||
| public final class FishHookStateChangeEvent extends EntityEvent { | ||
|
|
||
| private static final HandlerList HANDLER_LIST = new HandlerList(); | ||
|
|
||
| private final FishHook.HookState newHookState; | ||
|
|
||
| @ApiStatus.Internal | ||
| public FishHookStateChangeEvent(final FishHook entity, final FishHook.HookState newHookState) { | ||
| super(entity); | ||
| this.newHookState = newHookState; | ||
| } | ||
|
|
||
| /** | ||
| * Get the <strong>new</strong> hook state of the {@link FishHook}. | ||
| * | ||
| * <p>Refer to {@link FishHook#getState()} to get the current hook state.</p> | ||
| * | ||
| * @return the <strong>new</strong> hook state | ||
| */ | ||
| public FishHook.HookState getNewHookState() { | ||
| return this.newHookState; | ||
| } | ||
|
|
||
| @Override | ||
| public FishHook getEntity() { | ||
| return (FishHook) super.getEntity(); | ||
| } | ||
|
|
||
| @Override | ||
| public HandlerList getHandlers() { | ||
| return HANDLER_LIST; | ||
| } | ||
|
|
||
| public static HandlerList getHandlerList() { | ||
| return HANDLER_LIST; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.