Remove broken code#12171
Merged
Merged
Conversation
Owen1212055
approved these changes
Feb 23, 2025
Lulu13022002
force-pushed
the
up/rm-old-code
branch
from
3eb1fce to
0893d35
Compare
kennytv
approved these changes
Feb 25, 2025
github-project-automation
Bot
moved this from Awaiting final testing
to Merged
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current logic try to compare a MobEffect with a Holder<MobEffect> which always fail.
Generally this logic would need to be more involved with the recent tag/effect addition. I think it's better done via a plugin depending of the type of server.