ServerTickManager#requestGameToSprint - Silence command like feedback#12220
Merged
Conversation
Leguan16
reviewed
Mar 3, 2025
Machine-Maker
approved these changes
Mar 8, 2025
github-project-automation
Bot
moved this from Awaiting review
to Awaiting final testing
in Paper PR Queue
Owen1212055
approved these changes
Mar 8, 2025
github-project-automation
Bot
moved this from Awaiting final testing
to Merged
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to silence the feedback from server sprinting via the API.
When using the API to request the server to sprint:
https://jd.papermc.io/paper/1.21.4/org/bukkit/ServerTickManager.html#requestGameToSprint(int)
The tick manager still provides feedback as if the vanilla
/tick sprintcommand were run:When using the API to do this task, the server shouldn't be responding as if a command were run.
This has driven me nuts since Bukkit added this, I just kept forgetting to report it and/or actually do something about it.
But nows my chance.
One thing I did think was someone out there using this API might actually like this feedback?!?!?
So I was thinking, should I make another
ServerTickManager#requestGameToSprintmethod with an option to silence?Looking for feedback!