Registry API for supported Mob Variants#12364
Closed
BertTowne wants to merge 4 commits into
Closed
Conversation
Contributor
|
Changes between generated comments will be lost. Registration is now done in RegistryEntries in the generator module. I have some plan later to move that over a json file but for now that should do it. The registry don't need to be delayed too. |
Contributor
Author
|
Thank you, I have made the proposed changes and went forward with implementing the rest of the data-driven mob variants in a similar way to that of the Chicken Variants from before. |
github-project-automation
Bot
moved this from Awaiting review
to Closed
in Paper PR Queue
Member
|
Oop, please reopen a PR targeting main again |
This was referenced Apr 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#12350 Currently only implemented Chicken variants as a way to gather feedback before adding the rest. I'm especially wanting opinions on the best way to implement SpawnConditions to the API, as those have intentionally been left out of this, but right now custom mob variants are given
SpawnPrioritySelectors.EMPTY.ModelAndTexturehas been separated into Model and Texture for API purposes, as the vanilla-defined models are not entirely the same across each mob and are unfortunately stored as enums.assetIdis required, andmodelwill default to NORMAL.