Allow Server#getDefaultGameMode before worlds are initialized#12490
Merged
Conversation
lynxplay
approved these changes
Apr 28, 2025
github-project-automation
Bot
moved this from Awaiting review
to Awaiting final testing
in Paper PR Queue
lynxplay
force-pushed
the
default-gamemode
branch
from
143adfb to
a002315
Compare
Member
|
If the get fail in that phase then the set has the same issue? |
Contributor
|
There isn't much we can do in that case tho. We cannot modify the server properties state. |
Member
yeah i was thinking about that.. a Precondition with a state exception but that can be another PR not? or in this for avoid a +1 xd |
Contributor
|
Well, rn it doesn't fail at all, it just doesn't do anything. |
github-project-automation
Bot
moved this from Awaiting final testing
to Merged
in Paper PR Queue
NonSwag
added a commit
to NonSwag/Paper
that referenced
this pull request
Apr 28, 2025
Contributor
|
getMap has a similar issue if you want to look, also .overworld() exists too |
Sayakie
added a commit
to InstellarMC/Stellar
that referenced
this pull request
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of accessing the level directly we return the configured value from properties
Without fix
With fix
