Fix loadChunk(x, z, false)#2296
Closed
Spottedleaf wants to merge 10 commits into
Closed
Conversation
I was not correctly checking if the status was even cached.
Member
Author
|
Note to self: Resolved concerns but I need to review changes |
This is required for asynchronous IO. async io will require calls to getChunkStatusIfCached to return the chunk status for a chunk currently queued to save - this cannot be reasonably done with current ABI
10 tasks
zachbr
approved these changes
Jul 13, 2019
kashike
approved these changes
Jul 13, 2019
kashike
pushed a commit
that referenced
this pull request
Jul 13, 2019
LeonTG
pushed a commit
to LeonTG/Paper
that referenced
this pull request
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was not correctly checking if the status was even cached.