Add LZ4 support for region files#2376
Closed
egg82 wants to merge 1 commit into
Closed
Conversation
10 tasks
Contributor
Author
|
Zstd PR here: #2377 |
egg82
commented
Jul 27, 2019
| + // Paper start - LZ4 support | ||
| + if (PaperConfig.useLZ4Compression) { | ||
| + try (DataOutputStream out = new DataOutputStream(new BufferedOutputStream(new net.jpountz.lz4.LZ4FrameOutputStream(new java.io.FileOutputStream(file)), 32 * 1024))) { | ||
| + NBTCompressedStreamTools.writeNBT(oversizedData, out); |
Contributor
Author
There was a problem hiding this comment.
Need a return statement here
Contributor
Author
|
Closed in favor of #2377 which has this and is more complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using lz4-java: https://github.com/lz4/lz4-java
There's a new option in PaperConfig for this which defaults to false.
Since the patch hooks Mojang's versioning system for new compression methods, it
should be internally consistent, easily-updatable, and reversible with a force-upgrade.
This will likely conflict with plugins and programs expecting region files to be compressed using the current standard.