Skip to content

Add PlayerFlowerPotManipulateEvent#2459

Merged
Proximyst merged 1 commit into
PaperMC:masterfrom
MisterVector:PlayerManipulateFlowerPotEvent
Jan 3, 2021
Merged

Add PlayerFlowerPotManipulateEvent#2459
Proximyst merged 1 commit into
PaperMC:masterfrom
MisterVector:PlayerManipulateFlowerPotEvent

Conversation

@MisterVector
Copy link
Copy Markdown
Contributor

Added an event for when a player places an item in or takes an item out of a flower pot.

This is a revisit to an old PR I had submitted nearly 3 years ago but wasn't able to finish because of an issue with server-side code that handles event cancellation.

@zachbr zachbr self-requested a review September 23, 2019 14:54
@fgRuslan
Copy link
Copy Markdown

🌻

@fgRuslan
Copy link
Copy Markdown

💮 🌷

@Proximyst
Copy link
Copy Markdown
Contributor

Please don't spam comments.

@fgRuslan
Copy link
Copy Markdown

Sorry

Proximyst
Proximyst previously approved these changes Nov 14, 2020
Copy link
Copy Markdown
Contributor

@Proximyst Proximyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase, but lgtm.

--- /dev/null
+++ b/src/main/java/com/destroystokyo/paper/event/player/PlayerFlowerPotManipulateEvent.java
@@ -0,0 +1,75 @@
+package com.destroystokyo.paper.event.player;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+package com.destroystokyo.paper.event.player;
+package io.papermc.paper.event.player;

world.setTypeAndData(blockposition, block.getBlockData(), 3);
entityhuman.a(StatisticList.POT_FLOWER);
--
2.20.1.windows.1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My condolences 🤓

@MisterVector MisterVector force-pushed the PlayerManipulateFlowerPotEvent branch from 472e2dd to ccd1806 Compare December 10, 2020 20:37
@zachbr zachbr changed the base branch from ver/1.14 to master December 10, 2020 20:37
@zachbr zachbr requested a review from a team as a code owner December 10, 2020 20:37
@MisterVector
Copy link
Copy Markdown
Contributor Author

Alright rebased on top of latest. Had to change one line of code server-side due to latest server changes. Should be good to go!

zachbr
zachbr previously approved these changes Jan 3, 2021
@Proximyst
Copy link
Copy Markdown
Contributor

@limbo-app ready

Copy link
Copy Markdown

@limbo-app limbo-app left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request automatically approved for merging - a core team member has previously approved this pull request.

@Proximyst Proximyst enabled auto-merge (rebase) January 3, 2021 13:23
@Proximyst Proximyst merged commit 2c9ed43 into PaperMC:master Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feature Request for a new Feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants