Add api for getting direct entity cause of knockback

[Machine-Maker]

Closes #7168

[vytskalt]

When is this and #7171 getting merged?

[Machine-Maker]

I'm not entierly happy that EntityKnockbackByEntityEvent#getDirectHitBy() is nullable when it'll only be null if the legacy ctor is used. What if that return value was wrapped in a requireNonNull call? Cause it really should be notnull.

[vytskalt]

I'm not entierly happy that EntityKnockbackByEntityEvent#getDirectHitBy() is nullable when it'll only be null if the legacy ctor is used. What if that return value was wrapped in a requireNonNull call? Cause it really should be notnull.

Yes, I think its better to do that instead of keeping it nullable

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[vytskalt]

Still need this.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[vytskalt]

no

[Lulu13022002]

Is it worth to wait for #8058 and pass directly the damage source here and also for the PushEvent (another PR) ?

[vytskalt]

Hi, is there anything I can do to help this PR get merged at some point? It's been 2 years and I still need this API...

[lynxplay]

I think we may be better of deprecating the existing method and choosing some more descriptive names for this 👍