Skip to content

[WIP] Poi API#7187

Closed
Owen1212055 wants to merge 2 commits into
PaperMC:masterfrom
Owen1212055:poi-api
Closed

[WIP] Poi API#7187
Owen1212055 wants to merge 2 commits into
PaperMC:masterfrom
Owen1212055:poi-api

Conversation

@Owen1212055
Copy link
Copy Markdown
Member

@Owen1212055 Owen1212055 commented Dec 25, 2021

Allows methods for accessing poi blocks
An example is provided in the test plugin, where all nearby POI will be marked with a redstone block on top of it.

Documentation is not yet finished, feedback is welcome!!

@Owen1212055 Owen1212055 changed the title wip Poi API [WIP] Poi API Dec 25, 2021
@stale
Copy link
Copy Markdown

stale Bot commented Feb 23, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@Owen1212055
Copy link
Copy Markdown
Member Author

None of this is really exposed in the current API, feedback here would be appreciated.

@stale stale Bot removed the resolution: stale label Feb 25, 2022
@stale
Copy link
Copy Markdown

stale Bot commented Apr 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@Owen1212055
Copy link
Copy Markdown
Member Author

I'll finish this up and just let it sit here for any additional feedback.

@stale stale Bot removed the resolution: stale label Apr 27, 2022
@stale
Copy link
Copy Markdown

stale Bot commented Jun 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@Owen1212055
Copy link
Copy Markdown
Member Author

K

@Owen1212055
Copy link
Copy Markdown
Member Author

Darn phone decided to scroll right to the close button.

+ Collection<RegisteredPoi> getPoisInRange(@NotNull Location location, int range);
+
+ @Nullable
+ RegisteredPoi getClosestPoi(@NotNull Location location, int range, @NotNull Predicate<PoiType> poiTypePredicate, @NotNull Predicate<Location> locationPredicate);
Copy link
Copy Markdown
Contributor

@Lulu13022002 Lulu13022002 Aug 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe create the mirror function (locateNearestPOI) in bukkit world since there already locateNearestStructure and locateNearestBiome. Also why not the name PoiBlock instead of RegisteredPoi ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

2 participants