Improve GameRule API

[Machine-Maker]

Getting a gamerule's default value shouldn't be tied to needing a world instance since it's the same without a world. Also, the methods to get the gamerule's value for a world and default world should be notnull, so the methods I added to GameRule to get/set the world have an Objects.requireNonNull wrapped around them.

[kennytv]

I don't like how this duplicates all the methods for no real reason, the nullability change is just a confusing hack with the world method still being marked as nullable. Imo the getDefault in Server and the world methods in GameRule should be removed

[Machine-Maker]

I don't like how this duplicates all the methods for no real reason, the nullability change is just a confusing hack with the world method still being marked as nullable. Imo the getDefault in Server and the world methods in GameRule should be removed

I need the getDefault in server to have a way of getting the default rule value without a reference to the world. currently, the only way to get the default rule value requires a world, which is totally unneeded.

[kennytv]

Ah I didn't see GameRule is not an interface implemented in CraftBukkit

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[Machine-Maker]

Rebased for 1.18.2

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[Machine-Maker]

Rebased for 1.19.1