Added PermissibleBase getters and setters#8463
Conversation
|
Note: #8108 Do note that this expands the whole permission overriding and allows you to override the permission logic in the SimplePluginManager. |
|
Added the missing annotations causing tests to fail |
|
Did the requested changes |
|
this feels like the kind of thing that exposes internal details of api impl which makes evolving the permissions api harder, and makes it easier for plugin developers to make mistakes without any traceability. you'd be better off reworking how permissions are set and computed in the first place to remove the numerous footguns developers encounter when customizing permissions api logic - things like state tracking across the various join/quit/kick events, the permissions impact of recalculating permissions, and all the logic with default permissions |
|
The thing with evolving the perm API is that it's generally one of the many things which has been left to rot, hence why any perm plugin of note will literally just rip the thing out in order to add basic features, such as verbose mode, wildcards, etc I'm much open towards expanding this API, but, I'd much rather that be an effort kicked off through perm plugin devs whom know their needs here so that we can actually deliver towards it, but, at this point, people reflect into this mess anyways that I don't have a strong urge to deny this personally, but, did wanna ask people like Luck if they had any thoughts or considerations; It's not like exposing this in the API is a huge priority for us and I'd much rather see perm plugin devs discuss this sorta thing |
|
Closing, as in general as specified above it's best to instead expand this API instead of trying to move around it like this. |
Adding this API will remove the need to use reflections in plugins to get and set
PermissibleBaseonCraftHumanEntityto override permissions logic