Keep vanilla check for custom growth modifier for sugar cane and cactus#8555
Keep vanilla check for custom growth modifier for sugar cane and cactus#8555Lulu13022002 wants to merge 1 commit into
Conversation
…us + fix broken percent
lynxplay
left a comment
There was a problem hiding this comment.
I honestly think the entire concept of directly growing a cactus that is not age 15 is rather flawed.
I have a patch in the works for this, I'll open a PR for it this weekend so if you are fine with it I might supersede your PR.
See: e65b7ab
|
Yes, you're right but even growing the cactus from more than one is strange because then it will ignore some stage that will never be used, but then we can't support the greater modifier |
|
Yea, I mean if we had to actually get through every stage, we'd had to reschedule random ticks ? Especially in regards to the then unused stages. We could look into a gaussian distribution for the age growth instead of what my patch suggests rn to cover all ages. |
Closes #8544
The spigot growth modifier is broken for both sugar cane and cactus and the mentionned issue also happens for
sugar cane but it's more complex to reproduce (basically destroy the water source once placed and observe (vanilla will break the plant but not spigot one)
The old bahavior can possibly run two roll that also break the percent modifier
The new system handle correctly the percent in four stage
When modifier = 100: keep vanilla behavior
When modifier < 100: gives less chance to the plant to increase its own age
When modifer > 100 but < 1600: increase the age by more than one depending on the percent
When modifier >= 1600: fast grow, the age will not increase but they can grow directly even for an age smaller than 15
but to keep this consistent with vanilla we need to include the grow check in the same tick and not one tick after like usually