Fix chunk loading/sending when the rate is set to 1.0#8834
Closed
MartijnMuijsers wants to merge 1 commit into
Closed
Fix chunk loading/sending when the rate is set to 1.0#8834MartijnMuijsers wants to merge 1 commit into
MartijnMuijsers wants to merge 1 commit into
Conversation
MartijnMuijsers
force-pushed
the
fix/chunk-loading-rates-of-one
branch
2 times, most recently
from
ddadb88 to
200ab33
Compare
Owen1212055
approved these changes
Apr 2, 2023
Member
|
This doesn't seem to be needed anymore actually, the max rate is only used if the value in the config is less than 0.0, which means 1.0 will work fine now. |
Contributor
Author
|
In addition, the rate used to be in chunks/tick, so that the minimum was 20 chunks/second, which is quite high for a minimum settable bound. Now, the rate is in chunks/second, so that the minimum is 1 chunk/second, which I also expect to be low enough to cover all environments. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6616.
This allows the following
paper-global.ymlconfiguration values:global-max-concurrent-loadscan be set to 1.0 and higher(previously could only be set to strictly higher than 1.0)
target-player-chunk-send-rateandglobal-max-chunk-send-ratecan be set to 10-3 (1 chunk per 1000 seconds, a value that is safe and lower than anyone could ever need) and higher(previously could only be set to strictly higher than 1.0)