Skip to content

Migrate Gradle dependencies to version catalog#9383

Closed
TheRealRyGuy wants to merge 4 commits into
PaperMC:masterfrom
TheRealRyGuy:feature/versioncatalog
Closed

Migrate Gradle dependencies to version catalog#9383
TheRealRyGuy wants to merge 4 commits into
PaperMC:masterfrom
TheRealRyGuy:feature/versioncatalog

Conversation

@TheRealRyGuy
Copy link
Copy Markdown
Contributor

@TheRealRyGuy TheRealRyGuy commented Jun 23, 2023

Still todo - however I wanted to start a conversation about dependency updates

  • Review diff properly, didn't have time (marking this as a draft)
  • Sort version catalog (by sub project)

All this essentially does is migrate to use a gradle version catalog, to help group dependency versions and aide in ease of updating deps. This does sync up some dependencies (most notably asm), however I tried not to touch too many current dep versions. This also ensures on build workflow we use the gradle/wrapper-validation-action git action
The only testing done with this is making sure it builds

Note, fully aware some of these strictly can't be updated, this was a generated list

  • Gradle: 8.02 -> 8.1.1 (done)
Paper-API dependency updates
Paper-MojangAPI Dependency Updates
Paper-Server Dependency Updates

@TheRealRyGuy TheRealRyGuy requested a review from a team as a code owner June 23, 2023 02:13
@TheRealRyGuy TheRealRyGuy marked this pull request as draft June 23, 2023 02:13
@MiniDigger
Copy link
Copy Markdown
Member

I know that @jpenilla and @Machine-Maker were working on this last week
I think the idea was that we want to keep the deps associated with patches, thats why this simple approach you did here doesnt work for us

@codebycam
Copy link
Copy Markdown

Cheers for your PR! Unfortunately as Mini mentioned above this doesn't really suit Paper's current project structure.

@codebycam codebycam closed this Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

3 participants