Migrate Gradle dependencies to version catalog#9383
Closed
TheRealRyGuy wants to merge 4 commits into
Closed
Conversation
Member
|
I know that @jpenilla and @Machine-Maker were working on this last week |
|
Cheers for your PR! Unfortunately as Mini mentioned above this doesn't really suit Paper's current project structure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still todo - however I wanted to start a conversation about dependency updates
All this essentially does is migrate to use a gradle version catalog, to help group dependency versions and aide in ease of updating deps. This does sync up some dependencies (most notably asm), however I tried not to touch too many current dep versions. This also ensures on build workflow we use the
gradle/wrapper-validation-actiongit actionThe only testing done with this is making sure it builds
Note, fully aware some of these strictly can't be updated, this was a generated list
Paper-API dependency updates
http://findbugs.sourceforge.net/
https://github.com/google/gson
https://github.com/google/guava
http://fastutil.di.unimi.it/
https://github.com/SpigotMC/BungeeCord
https://logging.apache.org/log4j/3.x/
https://maven.apache.org/ref/${project.version}/
https://maven.apache.org/resolver/
https://maven.apache.org/resolver/
https://checkerframework.org/
http://hamcrest.org/JavaHamcrest/
https://github.com/mockito/mockito
http://asm.ow2.io/
http://asm.ow2.io/
http://www.slf4j.org
Paper-MojangAPI Dependency Updates
http://fastutil.di.unimi.it/
http://hamcrest.org/JavaHamcrest/
Paper-Server Dependency Updates
https://lmax-exchange.github.io/disruptor
https://github.com/classgraph/classgraph
http://netty.io/
http://netty.io/
https://github.com/FabricMC/mapping-io
https://logging.apache.org/log4j/3.x/
https://logging.apache.org/log4j/3.x/
https://maven.apache.org/ref/${project.version}/
https://maven.apache.org/resolver/
https://maven.apache.org/resolver/
http://hamcrest.org/JavaHamcrest/
https://github.com/mockito/mockito
http://asm.ow2.io/
http://asm.ow2.io/